Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set KubeOps.Generator as a DevelopmentDependency #834

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Set KubeOps.Generator as a DevelopmentDependency #834

merged 1 commit into from
Jan 6, 2025

Conversation

gamingrobot
Copy link
Contributor

Fixes: #698
This will cause dotnet add package to add this to the PackageReference automatically:

<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>

It will also show on nuget.org:
image

This flag is used by other source generators to fix the problem in #698

This flag is documented for .nuspec files but also works with dotnet pack in the csproj
image

@gamingrobot
Copy link
Contributor Author

I think the build was broken from the .NET 9 action upgrades? https://github.com/buehler/dotnet-operator-sdk/actions/runs/12634004387/job/35200831312

@buehler
Copy link
Owner

buehler commented Jan 6, 2025

Hi there :)

@buehler
Copy link
Owner

buehler commented Jan 6, 2025

Thanks for your contribution!
And yes, I think the build is broken with the .net 9 setting of preview stuff. I try to have a look at it

@buehler buehler merged commit 5a98290 into buehler:main Jan 6, 2025
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug]: Source generator fires for unit tests as well as operator
2 participants
@gamingrobot @buehler